fjebaker / SpectralFitting.jl

✨🛰 Fast and flexible spectral fitting in Julia.
https://fjebaker.github.io/SpectralFitting.jl
GNU General Public License v3.0
9 stars 5 forks source link

Add XS_Kerrconv model to convolutional.jl #128

Closed GloriaRAH closed 1 month ago

GloriaRAH commented 1 month ago

Adding a new convolutional model XS_Kerrconv

fjebaker commented 1 month ago

Test failing is not your fault

multifits: Error During Test at /home/runner/work/SpectralFitting.jl/SpectralFitting.jl/test/runtests.jl:96
  Got exception outside of a @test
  LoadError: MissingBackendError: Failed to use AutoReverseDiff().
  Backend package is probably not loaded. To fix this, try to run

      import ReverseDiff

  Stacktrace:

I will investigate this shortly.

fjebaker commented 1 month ago

Tested with

using SpectralFitting, Plots
model = XS_Kerrconv()
es = collect(range(0.1, 10.0, 200))
fs = allocate_model_output(model, es)
fs[100] = 1
plot(es[1:end-1], invokemodel!(fs, es, model))

image

Works fine!

fjebaker commented 1 month ago

I will merge this and then try and find out why the test suite is broken.