fjlopezs / mytracks

Automatically exported from code.google.com/p/mytracks
0 stars 0 forks source link

Japanese Translation #292

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Mercurial clone with changes to be reviewed:
* http://code.google.com/r/boiledorange73-201102/

Revisions to be pulled from that clone (or "all"):
* 18e093cea4

Purpose of code changes on the clone:
* Translation into Japanese

When reviewing my code changes, please focus on:
* MyTracks/res/values-ja/arrays.xml
* MyTracks/res/values-ja/strings.xml

Original issue reported on code.google.com by boiledor...@gmail.com on 3 Feb 2011 at 1:59

GoogleCodeExporter commented 9 years ago
Over all it looks really good.  Thanks for the up keep.  I could not comment on 
the file so I will put my comments here.

Can you remove all strings that are identical to the English strings?  The OS 
will back off to those values and we can save space by not having duplicates.  
For example please delete lines like:
<string name="kilometer_per_hour">km/h</string>

Original comment by sandordo...@google.com on 3 Feb 2011 at 3:35

GoogleCodeExporter commented 9 years ago
I see. strings.xml was changed.
All duplicated entries are commented-out,
and "<!-- duplicated -->" text is added at each commented-out line.

  Please pull from 33dab7997e (latest)

At 19d2170e35, They are actually commented-out.

arrays.xml does not have any array to be deleted, because it has one or more 
translated text(s).

Original comment by boiledor...@gmail.com on 4 Feb 2011 at 3:36

GoogleCodeExporter commented 9 years ago
I just pushed a version of your changes to head.  Please let me know if I 
screwed up any of the merges.  I deleted all untranslated strings.

Original comment by sandordo...@google.com on 4 Feb 2011 at 11:29

GoogleCodeExporter commented 9 years ago
I just pushed a version of your changes to head.  Please let me know if I 
screwed up any of the merges.  I deleted all untranslated strings.

Original comment by sandordo...@google.com on 4 Feb 2011 at 11:29

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
The entry named "sendtogoogle_google_fusiontables" in values-ja/strings.xml 
should be deleted. The word "Googleマイマップ" means "Google My Map", not 
"Fusion Tables".

I marked "duplicated" there, because Google have not provided a translated word 
for "Fusion Tables" yet.

Others are good.
Thank you for merging them !

Original comment by boiledor...@gmail.com on 5 Feb 2011 at 5:24

GoogleCodeExporter commented 9 years ago
Thanks for the clarification.  I reopened this to remind myself to delete it.

Original comment by sandordo...@google.com on 7 Feb 2011 at 4:47

GoogleCodeExporter commented 9 years ago
Please close this
because new Japanese translation including newly added entries was created and 
I have sent new isseue #292.

Original comment by boiledor...@gmail.com on 9 Mar 2011 at 3:57

GoogleCodeExporter commented 9 years ago

Original comment by sandordo...@google.com on 9 Mar 2011 at 8:03