aliases

[pawelbaranski]

Hi,

I know it is not a feature of Silex, but still, this is very useful one. Care to merge this PR :) ?

[fjorgemota]

Hey! Thanks for the PR. I'm thinking in some problems related to this approach:

• What if I run container.alias("some_alias", "some_alias");? Infinite loop?
• What if something like that is executed:

container.set("session.mysql", function(c) {
  // ....
});
container.alias("session", "session.mysql");
container.set("session", function() {
 // ....
});

A exception is emitted on the set of the session, after adding the alias, because well, the key already exists. Should we ignore alias in that case or not?

• What if I run

container.alias("alias_1", "alias_2");
container.alias("alias_2", "alias_1");

Infinite loop, again?

• What if I run

container.alias("session", "session.mysql")
var session = container.raw("session");

I think that session will not contain the original session.mysql function, right?

• By last, but not least important, it's not better to the developer to do these type of changes on his behalf? In the example you posted in README, I think that user_repository.file and user_repository.mysql will have different options (probably using parameters like user_repository.file.path for the first and user_repository.mysql.host, user_repository.mysql.user, user_repository.mysql.password and user_repository.mysql.database for the second), so to me makes sense to enable the developer to customize that in a better way, allowing it to directly use a parameter like user_repository.type and a service like so:

container.set("user_repository", function(c) {
    return c.get("user_repository."+c.get("user_repository.type"));
});

Or similar, not? Note that is for a similar reason that this exactly feature was not added to the original Pimple (see silexphp/Pimple#115): seems to be too simple to the developer to enable a behavior similar to that of an alias with flexibility (it can manage the alias like it want to) and ease of use.

What do you think?

[pawelbaranski]

This are some valid questions, I will address them as soon as I can

[fjorgemota]

Hello!

Any new updates?

By the way.

Two new points:

• What if the service being aliased is a factory?
• Symfony Dependency Injection Container seems to support aliasing directly in service definition, which is interesting (and opens less margin to things like infinite loops);