isFunction is not compatible with IE11

fjorgemota / jimple

Just a dependency injection container to NodeJS and to the browser using new ES6 features

MIT License

75 stars 12 forks source link

isFunction is not compatible with IE11 #72

Open Poyoman39 opened 4 years ago

Poyoman39 commented 4 years ago

Hey.

The internal "isFunction" function is not compatible with IE11, on which "fn.constructor.name" will return undefined. Causing this library doesn't work at all on IE11

fjorgemota commented 4 years ago

Hey.

Given that IE11 doesn't support ES6 (which is used by this library), I don't think this library should be adapted to support it, too, specially considering that IE11 isn't supported even by Microsoft, which used to develop it..

Poyoman39 commented 4 years ago

I agree with you. However it looks like most of your this is compatible with IE11 except this core functionality. I made a PR which is a potential simplification of this function. Feel free to integrate or not ;)