fjorgemota / jimple

Just a dependency injection container to NodeJS and to the browser using new ES6 features
MIT License
75 stars 12 forks source link

When are you going to release the new version (without the shrinkwrap)? #9

Closed homer0 closed 7 years ago

homer0 commented 7 years ago

The whole thing with ansi-styles (npm/npm#17723) messed up a few of my apps with Jimple. As a fix, I pointed the version on the package.json to this repo last commit, but I would prefer using a version from the registry :P.

Btw, thanks a lot for the package, pretty useful! Regards

fjorgemota commented 7 years ago

Hi!

I will work in some points related to the API documentation and will publish a new version for the package soon.

Sorry for the problems you're having. :(

homer0 commented 7 years ago

Thanks! If it doesn't bother you, can you keep the issue open until you make the release?

fjorgemota commented 7 years ago

No problem. That's the reason I did not close the issue yet. :P

fjorgemota commented 7 years ago

Hey,

I have updated the dependencies (with a help from Greenkeeper) and updated the shrinkwrap..Now, as far I know, there are no instances of ansi-styles in that shrinkwrap, and as far I know now all should be ok.

Can you test, @homer0, please?

PS: I found that Travis CI found some problems with the deploy of the documentation, however, the installation o the package should be really OK..

homer0 commented 7 years ago

@fjorgemota I'll try to test it today and let you know, thanks!

homer0 commented 7 years ago

@fjorgemota Sorry for the delay; It seems to be working now, but there's a detail: Not sure if it's related to the format of the shrinkwrap, but it now downloads the devDependencies, something it didn't do before. Also, it ignores npm 3+ symbolic links system and throws all on node_modules/jimple/node_modules.

Try this for example: Create a new empty package.json and then run:

npm i jimple@fjorgemota/jimple#95bcca21fb9480477857fcd6d4834a51313f0bf2

That will install just Jimple, but if you run this:

npm i jimple@1.4.3

It installs all the dev dependencies.

Btw, thanks so much for being so fast :D.

homer0 commented 7 years ago

@fjorgemota Were you able to find the reason for the dependencies issue?

fjorgemota commented 7 years ago

@homer0 Hey! Thanks for the test. =)

I think I will probably just delete npm-shrinkwrap (because the project just have devDependencies..) and will release a new version today. That should probably fix the issue.

By the way, sorry for the long delay. I like this project but i'm a bit busy in the last weeks working hard in another project to finish my Computer Science degree, so that's the reason behind the delay. =)

Anyway, thanks again for the testing. I will publish the new version today, I promise. =)

fjorgemota commented 7 years ago

@homer0 Version released!

Can you test version 1.4.6, please?

Thanks. =)

homer0 commented 7 years ago

@fjorgemota Hey! sorry for the delay, too much work lately.

No worries, I assumed you were busy and that's why I let a few days pass before asking again :P.

I just tested it, and it works perfectly! screen shot 2017-07-26 at 6 31 20 am

Thank you so much for the help!!! Good luck with the degree :D!!

(You can close the issue)

fjorgemota commented 7 years ago

@homer0 No problem about the delay.

Feel free to open another issue if you experience problems with this package again. =)

Thanks!