Add humidity from external sensor

fjs21 / homebridge-kumo

Control your Kumo cloud devices using Homebridge.

https://www.npmjs.com/package/homebridge-kumo

Apache License 2.0

33 stars 8 forks source link

Add humidity from external sensor #65

Closed LtHummus closed 2 years ago

LtHummus commented 2 years ago

This PR adds the ability to read the humidity from an external sensor (namely PAC-USWHS003-TH-1). There should not be any additional configuration needed to make this work, though it will only work if direct access is enabled.

I only was able to do hacky testing of this for those without temperature sensors, because all of my units have sensors attached to them.

LtHummus commented 2 years ago

Ha, good catch! (No one has ever accused me of being an accurate speller ;) ). I’ll fix that up tonight (and some of the things called out by the linter)

LtHummus commented 2 years ago

Spelled Humidity correctly :)
Fixed complaints from the linter (I usually write in Go at work, so you can see that seep in ;) )
Added support to set the battery state (see screenshot in resolved convo above)

edit: one note...seems like the Battery service is global for the accessory, so the battery state also shows under the HeaterCooler in the Home app. This doesn't seem like too much of a problem for now (though maybe there are other Mitsubishi accessories for these ACs that have their own batteries?)

Jason-Morcos commented 2 years ago

Hi @fjs21! Do you have an estimated release date for a release that includes these changes? Is there a way to/would it be helpful to beta test this change in some way?

Thanks!