fjs21 / homebridge-kumo

Control your Kumo cloud devices using Homebridge.
https://www.npmjs.com/package/homebridge-kumo
Apache License 2.0
33 stars 8 forks source link

Improve fan speed controls #70

Closed jasongin closed 1 year ago

jasongin commented 1 year ago

This change makes the fan speed controls work better in a few ways:

I tested these changes with both direct and cloud APIs. Some additional verification from another user/developer might be helpful, since there are some complex interactions here.

All of the changes are applied only to the "ductless" device class. Some of the improvements could be ported to the "simple" or generic device classes; please advise if you think this is necessary.

jasongin commented 1 year ago

I have another big change coming up that builds on this one, that supports disabling some functions. (I only care about air-conditioning and fans so I don't want to see a mode selector that offers heating.) But I'm going to bring that later as a separate PR, so they will each be easier to review.

Jason-Morcos commented 1 year ago

@jasongin With these improved fan selection options, how do you specify an "auto" fan speed?

jasongin commented 1 year ago

With these improved fan selection options, how do you specify an "auto" fan speed?

If the AC is on and the fan speed control is set to off, then fan runs in "auto" mode. If the AC is off and the fan speed is set to off, then the system is fully off.