search

fjuniorr / flowmapper

Mappings between elementary flows
MIT License
0 stars 1 forks source link

Add logging information to matching process #26

Closed fjuniorr closed 9 months ago

cmutel commented 10 months ago

I think this is poorly worded - instead of logging to a separate file, we can treat the mapping object as a log itself. Then instead of (or probably in addition to) the comment field we include a separate field stating which function or combination of functions produced the mapping object.

fjuniorr commented 9 months ago

I agree. And since I did not specify which information should be logged, it doesn't really help.

I've added the function name to the mapping entry in https://github.com/fjuniorr/flowmapper/commit/d520348cd676650255326ae4a13b05d55daebc4b and have left the comment as is for now.

I'm considering closing this and opening issues when specific information needs appear. Sounds good, @cmutel?

cmutel commented 9 months ago

@fjuniorr Can we close this?

fjuniorr commented 9 months ago

Yes!