search

fjuniorr / flowmapper

Mappings between elementary flows
MIT License
0 stars 1 forks source link

Enrich Simapro flows with CAS number before matching #74

Open fjuniorr opened 6 months ago

fjuniorr commented 6 months ago

Issue from https://github.com/fjuniorr/flowmapper/issues/8#issuecomment-1867316058.

There are at least two ways to go about this depending if must of the work will be done by users or flowmapper maintainers:

1) If the users would do must of the work then we don't need to change anything[^1]. The data transformation (ie. adding a cas number) can simply be provided as a data migration file and everything will work as expected.

2) If this should be a builtin[^2] it falls on flowmapper maintainers and we need to decide if it's better to add the information as constants or do a dynamic search during the match process[^3].

Maybe for now the best is to stick with 1 and create a data migration file from SProf94_final_substanceList.xlsx that can be used as needed by users.

[^1]: Maybe increase the priority of match_identical_cas_numbers?

[^2]: Such as context mapping

[^3]: Using something like CAS Common Chemistry API (I haven't looked their license terms nor pricing conditions)

cmutel commented 6 months ago

Maybe for now the best is to stick with 1 and create a data migration file from SProf94_final_substanceList.xlsx that can be used as needed by users.

Yes, this is the way.

Using something like CAS Common Chemistry API (I haven't looked their license terms nor pricing conditions)

Better to use ChemIDPlus, it's free and has the info we want.

fjuniorr commented 6 months ago

Ok, that was really fast! :sweat_smile: