search

fkelly12054 / juicebox-kelly

Juicebox moving towards Drupal 9
GNU General Public License v2.0
1 stars 1 forks source link

Consider incorporate this Juicebox Mutilangue Contrib Patch #12

Open D4KO opened 3 years ago

D4KO commented 3 years ago

Reading through Juicebox officel drupal.org issue tracker I found this multi-language issue. https://www.drupal.org/project/juicebox/issues/2976805

It's not up to date for us at the current stage of development. Still it's import one IMHO. Needs discussion.

When I finally set-up my local testing clear D9 instance (hopefully this weekend), I'll be able to have a close look at this.

fkelly12054 commented 3 years ago

I checked out the issue, then downloaded the juicebox 8.x-2.0-beta3 release from Drupal dot org. I file compared the JuiceboxXmlControllerField.php files from (a) what we have here and (b) the beta3 release. There are differences. I just posted a request for confirmation about whether the users are experiencing this.

D4KO commented 3 years ago

I see.

On Thu, Dec 3, 2020 at 10:11 PM fkelly12054 notifications@github.com wrote:

I checked out the issue, then downloaded the juicebox 8.x-2.0-beta3 release from Drupal dot org. I file compared the JuiceboxXmlControllerField.php files from (a) what we have here and (b) the beta3 release. There are differences. I just posted a request for confirmation about whether the users are experiencing this.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/fkelly12054/juicebox-kelly/issues/12#issuecomment-738314394, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQHTBCQUWFPNDESHUBYPFTSS75JTANCNFSM4UMQA6AQ .

D4KO commented 3 years ago

I can't delete my SPAM messages. So I marked them as SPAM. Hopefully will disappear soon.

On Thu, Dec 3, 2020 at 10:14 PM DK koutas@gmail.com wrote:

I see.

On Thu, Dec 3, 2020 at 10:11 PM fkelly12054 notifications@github.com wrote:

I checked out the issue, then downloaded the juicebox 8.x-2.0-beta3 release from Drupal dot org. I file compared the JuiceboxXmlControllerField.php files from (a) what we have here and (b) the beta3 release. There are differences. I just posted a request for confirmation about whether the users are experiencing this.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/fkelly12054/juicebox-kelly/issues/12#issuecomment-738314394, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQHTBCQUWFPNDESHUBYPFTSS75JTANCNFSM4UMQA6AQ .