search

fkelly12054 / juicebox-kelly

Juicebox moving towards Drupal 9
GNU General Public License v2.0
1 stars 1 forks source link

Dk juicebox 3184078 #15

Closed D4KO closed 3 years ago

D4KO commented 3 years ago

Defines new juicebox.sites library. Attaches the library in JuiceboxFormatter.php prinarly from 'sites/all/libraries/juicebox/juicebox.js', secondary from '/libraries/juicebox/juicebox.js. juicebox.js is included only on pages with Juicebox Gallery (apparently when JuiceboxFormatter is used).

fkelly12054 commented 3 years ago

I will download this and test.

D4KO commented 3 years ago

I've got it working even with the aggregation... /libraries/juicebox/juicebox.js: {preprocess: false, minified: true} preprocess:false excludes the file from the Drupal aggregation

On Sun, Dec 13, 2020 at 2:31 PM fkelly12054 notifications@github.com wrote:

Merged #15 https://github.com/fkelly12054/juicebox-kelly/pull/15 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fkelly12054/juicebox-kelly/pull/15#event-4106021896, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQHTBCPTMUEHXOP7NU4FFDSUS645ANCNFSM4UZPOBKQ .

D4KO commented 3 years ago

not the clear solution. better than broken Juicebox with Drupal aggregation...

On Sun, Dec 13, 2020 at 3:05 PM DK koutas@gmail.com wrote:

I've got it working even with the aggregation... /libraries/juicebox/juicebox.js: {preprocess: false, minified: true} preprocess:false excludes the file from the Drupal aggregation

On Sun, Dec 13, 2020 at 2:31 PM fkelly12054 notifications@github.com wrote:

Merged #15 https://github.com/fkelly12054/juicebox-kelly/pull/15 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fkelly12054/juicebox-kelly/pull/15#event-4106021896, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQHTBCPTMUEHXOP7NU4FFDSUS645ANCNFSM4UZPOBKQ .

fkelly12054 commented 3 years ago

yes. it works nicely on Drupal 8.9 here. I am working on creating a new content type on my local Drupal site to upload one of my "prebuilt" galleries in and test. The one thing I will need to look at is that we follow the embed instructions and load the juicebox library js in the body (source view) of the content item. I think Drupal will just ignore that and not "double load" it but I'll know in about 15 minutes.

I put links to the documentation both in the issues queue of Drupal and here (I think). I can see you found it (or found it independently). I didn't know how to do that #attach thing you did buildEmbed function of juiceboxformatter.php. Cool! That's what I was struggling with ... where and how to load the library. That's great! I am not seeing any error messages yet.

I'll report back when I complete Drupal 9 testing with a pre-built gallery but it looks good.

D4KO commented 3 years ago

OKay. I hope we've won another battle. God knows how many other fights we'll have to fight to win this war... But it looks we're getting into it :)

On Sun, Dec 13, 2020 at 3:15 PM fkelly12054 notifications@github.com wrote:

yes. it works nicely on Drupal 8.9 here. I am working on creating a new content type on my local Drupal site to upload one of my "prebuilt" galleries in and test. The one thing I will need to look at is that we follow the embed instructions and load the juicebox library js in the body (source view) of the content item. I think Drupal will just ignore that and not "double load" it but I'll know in about 15 minutes.

I put links to the documentation both in the issues queue of Drupal and here (I think). I can see you found it (or found it independently). I didn't know how to do that #attach thing you did buildEmbed function of juiceboxformatter.php. Cool! That's what I was struggling with ... where and how to load the library. That's great! I am not seeing any error messages yet.

I'll report back when I complete Drupal 9 testing with a pre-built gallery but it looks good.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fkelly12054/juicebox-kelly/pull/15#issuecomment-744014090, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQHTBA2Q4QAHIG3YVGGJI3SUTEBVANCNFSM4UZPOBKQ .