D4KO
commented
3 years ago I've hit on bugs earlier when using juicebox gallery built with Drupal Views. http://sandboxd9.test.pink-future.cz/cs/gallery It works fine with image field juicebox formatter display but the gallery is not displayed on the page with View format juicebox display settings. I'll need to do more testing and debugging on this issue.
Until we resolve this issue and the 'pre-built' gallery issues, it still dev version
On Sun, Dec 13, 2020 at 3:53 PM fkelly12054 notifications@github.com wrote:
Okay. I cloned my "pre-built" Gallery content type from Drupal 8 to Drupal 9 local test site. Manually created the needed content type on Drupal 9 (I have several "extra" fields in it that I use for retrieving and ordering the galleries for my wife's "web-site" which has a separate domain ( sculptandprint.com) from my normal fkelly.org). Long and short: the gallery "works" and the recent log messages area is clean. I will build a gallery using media items later today. And retry the configuration screens both from config/media/juicebox and the "extend" screen. Then I'll run everything back through PHPCS.
Is there anything else you can think of? The work you did here is great! I was struggling to get the library js load to work correctly. Freely admit I was over my head in terms of Drupal coding.
If you are ready I'll email Neslee and send him an invite to this repository. He should just clone this onto Drupal dot org git site and build a release from it. I think there are other Drupal 9 readiness checks that will need to be run there. I'll invite him to review as much as he wants.
We'll definitely want a alpha/beta or dev type release of this so people aren't testing on their production sites.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fkelly12054/juicebox-kelly/pull/16#issuecomment-744018780, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQHTBAMZXDDRLGYUVHQNHLSUTIOVANCNFSM4UZQVVCA .
Okay. I cloned my "pre-built" Gallery content type from Drupal 8 to Drupal 9 local test site. Manually created the needed content type on Drupal 9 (I have several "extra" fields in it that I use for retrieving and ordering the galleries for my wife's "web-site" which has a separate domain (sculptandprint.com) from my normal fkelly.org). Long and short: the gallery "works" and the recent log messages area is clean. I will build a gallery using media items later today. And retry the configuration screens both from config/media/juicebox and the "extend" screen. Then I'll run everything back through PHPCS.
Is there anything else you can think of? The work you did here is great! I was struggling to get the library js load to work correctly. Freely admit I was over my head in terms of Drupal coding.
If you are ready I'll email Neslee and send him an invite to this repository. He should just clone this onto Drupal dot org git site and build a release from it. I think there are other Drupal 9 readiness checks that will need to be run there. I'll invite him to review as much as he wants.
We'll definitely want a alpha/beta or dev type release of this so people aren't testing on their production sites.