search

fkelly12054 / juicebox-kelly

Juicebox moving towards Drupal 9
GNU General Public License v2.0
1 stars 1 forks source link

fixes: Pro config options not parsed properly #19

Closed D4KO closed 3 years ago

D4KO commented 3 years ago

The regression was introduced with previous changes (commit #b72b6e9) concerning coding standards.

https://git.drupalcode.org/project/juicebox/-/blob/8.x-2.x/src/JuiceboxFormatter.php line 395

list($full_match, $name, $value) = $matches; was changed to list($name, $value) = $matches; to prevent 'Unused variable $full_match '... This change breaks parsing of manual Pro config options due to missing param in list command. https://www.php.net/manual/en/function.list.php

We should definitely review all commits concerning list command to fix other potential regressions we didn't noticed until now.

fkelly12054 commented 3 years ago

I will run a full coding standards review, both the base and the DrupalStandards one, in the next day or two. I'll post the results and we can make sure there are no further regressions.