Pushed componentDidMount isComponentVisible call into next tick

fkhadra / react-on-screen

Check if a react component in the viewport

https://fkhadra.github.io/react-on-screen/

MIT License

405 stars 50 forks source link

Pushed componentDidMount isComponentVisible call into next tick #17

Closed tapayne88 closed 6 years ago

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling f3da3b4a4cee0eaf09874e318b5aa445bb29aef9 on tapayne88:feature/componentDidMount-next-tick into 3b3074c311274189b9e58e747aa19bfc6234eb0e on fkhadra:master.

tapayne88 commented 6 years ago

Hi @fkhadra, thanks for the pointer! Think I should have got it now. Made it so all tests run through the setup step as wanted to ensure componentDidMount always sets up the component the same.

fkhadra commented 6 years ago

Good job! Thanks for that!