Next - Githubissues

fkhadra / react-on-screen

Check if a react component in the viewport

https://fkhadra.github.io/react-on-screen/

MIT License

405 stars 50 forks source link

Next #33

Closed fkhadra closed 5 years ago

fkhadra commented 5 years ago

Upgrade devTools
Added a playground. Just run yarn start
Removed componentWillReceiveProps
Rely on PureComponent instead of implementing shouldComponentUpdate

fkhadra commented 5 years ago

Hey @kafein I made a small change to your PR. tag only allow string for the moment, ref cannot be used with functional component. Anyway I think that the custom html tag will help a lot.

coveralls commented 5 years ago

Coverage decreased (-0.03%) to 96.907% when pulling 82124333dd8e0366b8f3cc5639a6f9043af7f250 on next into 7d672bb375063e191311a686e426e9a25408bb4a on master.