search

fkhadra / react-toastify

React notification made easy 🚀 !
https://fkhadra.github.io/react-toastify/introduction
MIT License
12.33k stars 676 forks source link

Add `isLoading` prop to the `IconProps` #1003

Closed kaciakmaciak closed 5 months ago

kaciakmaciak commented 9 months ago

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

The icon prop props argument` is an object with the following signature:

export interface IconProps {
  theme: Theme;
  type: TypeOptions;
}

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:

What is the expected behavior?

Could we please add isLoading to the IconProps so that we can display the spinner in that case? Currently, the spinner is hidden in case custom icon prop is provided.

export interface IconProps {
  theme: Theme;
  type: TypeOptions;
  isLoading: boolean;
}

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

N/A

I'm happy to contribute to resolve this.

Thanks so much!