fkhadra / react-toastify

React notification made easy 🚀 !
https://fkhadra.github.io/react-toastify/introduction
MIT License
12.33k stars 676 forks source link

fix(demo): the demo's <ToastContainer /> code isn't working with transition #1087

Open niyasrad opened 3 months ago

niyasrad commented 3 months ago

Do you want to request a feature or report a bug? Report a bug, from the demo.

What is the current behavior?

What is the expected behavior? The demo is supposed to return the accurate container configuration, which is,

<ToastContainer
      position="bottom-right"
      autoClose={3000}
      hideProgressBar={false}
      newestOnTop={false}
      closeOnClick
      rtl={false}
      pauseOnFocusLoss
      draggable
      pauseOnHover
      theme="dark"
      transition={Bounce}
/>

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React? This code, when copied- wouldn't work in any React version, or OS, or browser. It would throw an error and crash the DOM instead.

Additional Information/ Screenshot

image

AmmarTheDeveloper commented 1 month ago

I am searching this in the code for fixing this bug. but i am not able to find where it is set when i set the project locally and i run then i get a different output and page where transition is not mentioned in the Toast Emitter and Toast Container

niyasrad commented 1 month ago

I am searching this in the code for fixing this bug. but i am not able to find where it is set when i set the project locally and i run then i get a different output and page where transition is not mentioned in the Toast Emitter and Toast Container

it is noted, because I tried the same. I believe they haven't updated their CI, or triggered an actual demo replacement with the new code.

@fkhadra can you help here