Open hufftheweevil opened 1 month ago
Doing some more testing, I found that adding a pending
to (at least) the 2nd call will yield the expected the results.
But looking through the code, it shouldn't be required. If no pending
is given, then no id
is set inside handlePromise()
, so when it's time to resolve()
, it should be creating a fresh new toast and not touch the other. I can't figure out why it's affecting the other.
Found the issue, PR submitted https://github.com/fkhadra/react-toastify/pull/1112
What is the current behavior?
When calling two promises in a row, if one has a
success
defined, but the other does not, then the first one closes instantly. Example:If you uncomment the
success
on the 2nd one, then all works well.What is the expected behavior?
success
shouldn't be required. When absent, it shouldn't affect other toasts.Note: Adding a
toastId
does not help.Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React v18.2.0; not tested in other versions Tested in Chrome and Firefox
BTW, awesome package! Simple and beautiful.