search

fkhadra / react-toastify

React notification made easy 🚀 !
https://fkhadra.github.io/react-toastify/introduction
MIT License
12.58k stars 692 forks source link

`autoClose` is not respected when manually setting `progress` to 1 #1116

Open danny-does-stuff opened 4 months ago

danny-does-stuff commented 4 months ago

Do you want to request a feature or report a bug? Report a bug

What is the current behavior? When manually setting progress to 1 via toast.update(toastId, { progress: 1 }), the toast auto closes even when autoClose: false is set.

Steps to Reproduce + Repro:

  1. Create a toast that should not auto close using const toastId = toast('your message', { autoClose: false })
  2. update the toast's progress manually using toast.update(toastId, { progress: 1 })
  3. See the toast autoclose :(

CodeSandbox: https://codesandbox.io/p/sandbox/react-toastify-autoclose-with-progress-n5d5jg

What is the expected behavior? If I use autoClose: false, then the toast should not close automatically

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React? React 18, chromium based browser on Mac. I'm uncertain how this behaves on old versions of React

shamoilarsi commented 3 months ago

found this while going through the code, see if it helps you

danny-does-stuff commented 3 months ago

@shamoilarsi this still does not give the desired behavior. The suggestion in that code will remove the progress bar completely, which I don’t want, I want to see a completed progress bar.