fkhadra / react-toastify

React notification made easy 🚀 !
https://fkhadra.github.io/react-toastify/introduction
MIT License
12.33k stars 676 forks source link

closeOnClick still requires disabling #1128

Open viveleroi opened 1 week ago

viveleroi commented 1 week ago

We just updated to v10.0.5 from v9.x. The docs for v10 say closeOnClick now defaults to false, however in our tests that's not true.

With it set to false like the following code, toasts do not close when clicked (unless they click a dismiss button). Removing this prop enables the close-on-click functionality, I can now close the toasts when clicking anywhere on them.

  <ToastContainer
    autoClose={5000}
    className={styles.notificationToasts}
    closeButton={CloseButton}
    closeOnClick={false} // removing this enables the functionality
    hideProgressBar
    newestOnTop
    toastClassName={styles.notificationToast}
    transition={slideTransition}
  />