search

fkhadra / react-toastify

React notification made easy 🚀 !
https://fkhadra.github.io/react-toastify/introduction
MIT License
12.72k stars 700 forks source link

2.2.2 requires glamor #79

Closed the-spyke closed 6 years ago

the-spyke commented 6 years ago

Just updated react-toastify to 2.2.2 from npm and it broke my build:

ERROR in ./node_modules/react-toastify/lib/ProgressBar.js
Module not found: Error: Can't resolve 'glamor' in '/home/.../node_modules/react-toastify/lib'
 @ ./node_modules/react-toastify/lib/ProgressBar.js 17:14-31
 @ ./node_modules/react-toastify/lib/Toast.js
 @ ./node_modules/react-toastify/lib/ToastContainer.js
 @ ./node_modules/react-toastify/lib/index.js
 @ ./lib/.../action/notificationsactions.js
 @ ./lib/.../action/notificationsactions_test.js
 @ ./testfiles/unit_tests.js
webpack: Failed to compile.
mrbeen351 commented 6 years ago

Same issue with version 2.2.0 and toastify display incorrect with me, although it ran fine on last week

the-spyke commented 6 years ago

2.2.1 runs fine for me.

csvan commented 6 years ago

A temporary fix is adding glamor as a dep for your own project.

fkhadra commented 6 years ago

sorry guys I'll fix it asap. You could upgrade to the v3

FallenAngel666 commented 6 years ago

Same issue with 2.2.1 on my side.

fkhadra commented 6 years ago

@FallenAngel666 can you upgrade to the latest version(v3) ?

FallenAngel666 commented 6 years ago

Yeah, I guess "Can't resolve 'react-toastify/dist/ReactToastify.min.css' in" is just version related ^^

fkhadra commented 6 years ago

Indeed, since v3 I switched to glamor so no need to import the css. I'll check if there is a way to add deprecation notice when npm update the package.

FallenAngel666 commented 6 years ago

Thank you :)