search

fkhadra / react-toastify

React notification made easy 🚀 !
https://fkhadra.github.io/react-toastify/introduction
MIT License
12.33k stars 676 forks source link

CloseButton type definition is wrong #972

Closed thejayhaykid closed 5 months ago

thejayhaykid commented 1 year ago

Fix for issue #971 Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test).
  5. Run yarn start to test your changes in the playground.
  6. Update the readme is needed
  7. Update the typescript definition is needed
  8. Format your code with prettier (yarn prettier-all).
  9. Make sure your code lints (yarn lint:fix).

Learn more about contributing here