search

fkie-cad / dewolf

A research decompiler implemented as a Binary Ninja plugin.
GNU Lesser General Public License v2.1
162 stars 9 forks source link

Typing of function_parameters #267

Closed NeoQuix closed 11 months ago

NeoQuix commented 1 year ago

Proposal

DecompilerTask._function_parameters are type hinted by a List[Variable] but they are a List[Parameter]. Fix typing/stages which use them.

Approach

After looking into all stages, it is safe to lift them as a list of variables and remove Parameter from types.

NeoQuix commented 1 year ago

/cib

github-actions[bot] commented 1 year ago

Branch issue-267-Typing_of_function_parameters created!

NeoQuix commented 1 year ago

FuncDef is also never used in any way. The lifter does not even create it because we never lift a binary ninja FunctionType directly

NeoQuix commented 1 year ago

... Fixes name generation for hungarian