[Decoration] Exporting of rendered plots fails on windows

fkie-cad / dewolf

A research decompiler implemented as a Binary Ninja plugin.

GNU Lesser General Public License v2.1

172 stars 9 forks source link

[Decoration] Exporting of rendered plots fails on windows #370

Closed github-actions[bot] closed 9 months ago

github-actions[bot] commented 10 months ago

closes #369

rihi commented 10 months ago

Note, that the same issue theoretically exists for export_ascii aswell. However as far as I could see, graph-easy only reads input from files, so passing it via stdin is not possible.

rihi commented 10 months ago

~~I think we could use in-memory "files" for the exporting tests. Then the tests don't have to interact with the filesystem. See https://docs.python.org/3/library/io.html#binary-i-o~~ Oh, sorry just realised that export_plot always writes to a file. Perhaps it would make sense to change the api of export_plot to allow specifying an output handle?