[Code Quality] Remove wildcard import - Githubissues

fkie-cad / dewolf

A research decompiler implemented as a Binary Ninja plugin.

GNU Lesser General Public License v2.1

162 stars 9 forks source link

[Code Quality] Remove wildcard import #371

Closed blattm closed 7 months ago

blattm commented 7 months ago

This commit removes the wildcard import from .branches import * and replaces it with explicit imports.

Reasons to do so:

The wildcard import unnecessarily pollutes the namespace of cfg with all of branches imports.
The aforementioned pollution caused typecheckers and linters to partially fail because of weird side effects.
"Explicit is better than implicit" (The Zen of Python)