fkie-cad / fact_extractor

Standalone Utility for FACT-like extraction
GNU General Public License v3.0
80 stars 31 forks source link

added v0.1 of the microtik extractor based on @botlabDev's work #52

Closed dorpvom closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #52 into master will decrease coverage by 0.03%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   88.56%   88.53%   -0.04%     
==========================================
  Files         111      113       +2     
  Lines        3139     3174      +35     
==========================================
+ Hits         2780     2810      +30     
- Misses        359      364       +5     
Impacted Files Coverage Δ
...t_extractor/plugins/unpacking/microtik/code/npk.py 75.00% <75.00%> (ø)
...ractor/plugins/unpacking/microtik/test/test_npk.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f3971b...8708aa1. Read the comment docs.

weidenba commented 4 years ago

Parsing the output, which seems to be a python list object, would be nice. However it works for now and can be merged if CI passes