search

fkie-cad / fact_extractor

Standalone Utility for FACT-like extraction
GNU General Public License v3.0
80 stars 31 forks source link

uboot plugin: fix UnicodeDecodeError in image_name #79

Closed ckudera closed 3 years ago

ckudera commented 3 years ago

This PR addresses issue #78

It seems that some uboot images don't contain UTF-8 decodeable image names (e.g., the provided US_W312AV1.0BR_V2.0.0.3(1330)_EN_TDE.bin in issue #78). Currently, this leads to an UnicodeDecodeError, which is addressed by this PR.

codecov[bot] commented 3 years ago

Codecov Report

Merging #79 (c550c0c) into master (c4ab846) will decrease coverage by 0.09%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   89.81%   89.72%   -0.10%     
==========================================
  Files         124      124              
  Lines        3772     3777       +5     
==========================================
+ Hits         3388     3389       +1     
- Misses        384      388       +4
Impacted Files Coverage Δ
...lugins/unpacking/uboot/internal/uboot_container.py 84.74% <33.33%> (-6.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4ab846...c550c0c. Read the comment docs.