fkie-cad / fact_extractor

Standalone Utility for FACT-like extraction

GNU General Public License v3.0

80 stars 31 forks source link

update Dockerfile to focal #89

Closed wideglide closed 2 years ago

wideglide commented 2 years ago

use the phusion/baseimage:focal-1.1.0 and update openjdk to v16

Is there any reason not to update the published docker image?

jstucke commented 2 years ago

Hi, thank you for your contribution!

Is there any reason not to update the published docker image?

Not really. The only problem is: Since the changes to Docker Hub, the image is no longer built automatically. We still need a workaround for that.

wideglide commented 2 years ago

Can you build on GitHub and push? https://github.com/marketplace/actions/build-and-push-docker-images

Or is it that you need to pay to host on Docker Hub now?

wideglide commented 2 years ago

for reference I built this docker image in the release branch and pushed to a personal repository on Docker Hub.

jstucke commented 2 years ago

It should work with a GitHub action, because pushing the images yourself still works (only building on Docker Hub doesn't work without an upgraded license). I will look into this.

On the topic of the PR: I could not get the newly built image to work yet, but this seems to be due to unrelated problems that occurred in the meantime (e.g. https://github.com/fkie-cad/fact_extractor/issues/90). We will try to fix the issues first in order to make sure everything works.

dorpvom commented 2 years ago

Hi :wave: PR #91 fixed the unrelated issues concerning our binwalk integration. Can you merge our current master into your fork so that we can verify that everything's fine using our CI? Thanks for the Contribution!

wideglide commented 2 years ago

I also had an issue with cstruct when I ran the tests. In install.py cstruct is pinned to v1.8, but then when jefferson-3 is installed, I believe it updates cstruct as it is a dependency (unpinned) for jefferson-3. I opened an PR (https://github.com/sviehb/jefferson/pull/34), but I'm not sure how responsive the maintainers are.

wideglide commented 2 years ago

closes #85

codecov[bot] commented 2 years ago

Codecov Report

Merging #89 (db8dad2) into master (77b90f3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files         124      124           
  Lines        3794     3794           
=======================================
  Hits         3406     3406           
  Misses        388      388

Impacted Files	Coverage Δ
fact_extractor/install/unpacker.py	`0.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5072a68...db8dad2. Read the comment docs.