search

fkie / multimaster_fkie

ROS stack with FKIE packages for multi-robot (discovering, synchronizing and management GUI)
BSD 3-Clause "New" or "Revised" License
272 stars 106 forks source link

removed hostname namespace #109

Closed faizansid77 closed 5 years ago

faizansid77 commented 5 years ago

Pull request with reference to #108

atiderko commented 5 years ago

thank you for contribution.

  1. I would prefer to add a parameter to avoid breaking API (e.g. addns with True as default value).
  2. The anonym name can be set in launch file. So I would not change it in the source code. To avoid problems while master_sync is enabled, I added param_sync to ignored nodes.

Can you update the pull request, please.