search

fkie / multimaster_fkie

ROS stack with FKIE packages for multi-robot (discovering, synchronizing and management GUI)
BSD 3-Clause "New" or "Revised" License
267 stars 107 forks source link

Python 3 compatibility #123

Closed stertingen closed 3 years ago

stertingen commented 4 years ago

There are a few except usages, which are invalid for python 3: https://github.com/fkie/multimaster_fkie/blob/master/fkie_master_sync/src/fkie_master_sync/master_sync.py#L137, https://github.com/fkie/multimaster_fkie/blob/master/fkie_master_discovery/src/fkie_master_discovery/master_discovery.py#L937

Also, will there be a python 3 compat update for the melodic branch (old master)? If yes, I might put some effort into a PR.

atiderko commented 4 years ago

hi, sorry for delayed answer!

There are no plans to update the melodic branch to python 3. For Ubuntu 20.04 I plan to release the master branch with new node manager. I will accept PRs for master branch with python 3 compatibility fixes as long as they no break the python 2.7 support.

If needed I can add a new melodic python 3 branch and put in your PR.

stertingen commented 4 years ago

I've started some work here: https://github.com/fkie/multimaster_fkie/pull/124

Any feedback is welcome.

atiderko commented 4 years ago

Is there a reason why you did not use the new version in master branch? The new version does not change the behavior of master_discovery and master_sync, apart from the renaming. Furthermore a lot of code of the node manager is already python 3 compatible. And with your changes also master_discovery and master_sync would be python 3 compatible ;-)

stertingen commented 4 years ago

Is there a reason why you did not use the new version in master branch? The new version does not change the behavior of master_discovery and master_sync, apart from the renaming.

Well, there is no real reason, I thought the changes were bigger and incompatible to the old master, so I did not really look there. I will look into the new master branch now for inspiration.

Furthermore a lot of code of the node manager is already python 3 compatible. And with your changes also master_discovery and master_sync would be python 3 compatible ;-)

Okay then, guess it won't be long until that PR is ready to merge.

atiderko commented 4 years ago

Hi, I fixed (I hope all) python 3 compatibility problems for master branch. Currently the package.xml file contains no python3 dependencies, because the pull requests for required dependencies in rosdep are currently pending. But the code should be executable with python 3.

atiderko commented 3 years ago

The current version is Python 3 compatible and runs with ROS noetic. Please reopen on some problems!