fkie / multimaster_fkie

ROS stack with FKIE packages for multi-robot (discovering, synchronizing and management GUI)
BSD 3-Clause "New" or "Revised" License
267 stars 107 forks source link

Syncing parameters #174

Closed caiofis closed 1 year ago

caiofis commented 2 years ago

Hi @atiderko, once again thank you for the package. I am using multimaster for a while now and it has been great. I ran into a problem this week trying to set a parameter from a node that is not been synced. I am using two host computers, on computer A there are lots of nodes running and since we have a limited bandwidth I do not sync every node to computer B. But when I list the ros parameters on computer B I can only see those related with the synced nodes. I tried to run rosrun master_sync_fkie param_sync.py _add_ns:=False hoping that it would sync all the parameters, but without success. Is there a way to sync the parameters of a node without adding it sync_nodes?

atiderko commented 2 years ago

hi @caiofis I haven't used sync param for a long time. Apparently the API of MasterProxy has changed. I updated the script. Can you test it now?

caiofis commented 2 years ago

I tested it right now, but it didn't synced any new parameter. Do I just have to run rosrun fkie_master_sync param_sync.py _add_ns:=False on both machines and I should get all the parameters synced? Just in case, I am trying to change these parameters using dynamic_reconfigure, should the script work in this scenario?

atiderko commented 2 years ago

Hi @caiofis, the parameters are only synchronized on a change event caused by adding or removing a node, topic or service.

On parameter changes using dynamic_reconfigure no parameters synchronization will be executed. dynamic_reconfigure sets the parameter on the node direct.