search

fkie / multimaster_fkie

ROS stack with FKIE packages for multi-robot (discovering, synchronizing and management GUI)
BSD 3-Clause "New" or "Revised" License
268 stars 108 forks source link

Use ROS_HOSTNAME before ROS_IP. #33

Closed mikeodr closed 8 years ago

mikeodr commented 8 years ago

To determine which interface to use follow ROS master convention of ROS_HOSTNAME being used before ROS_IP.

This is as per: http://wiki.ros.org/ROS/EnvironmentVariables#ROS_IP.2BAC8-ROS_HOSTNAME

mikeodr commented 8 years ago

@mikepurvis @paulbovbel FYI

roehling commented 8 years ago

I agree that early return makes the control flow a bit easier to grasp, so I took the liberty to change the code accordingly

mikeodr commented 8 years ago

Excellent thanks for the quick merge and fixup!

Is a bloom to 0.5.1 possible?

roehling commented 8 years ago

I'd prefer to leave the bloom release to @atiderko. He will be back in office next week.

mikepurvis commented 8 years ago

Much obliged, thanks to you both.