fkie / multimaster_fkie

ROS stack with FKIE packages for multi-robot (discovering, synchronizing and management GUI)
BSD 3-Clause "New" or "Revised" License
267 stars 108 forks source link

Node naming limitations #63

Closed gstavrinos closed 6 years ago

gstavrinos commented 7 years ago

We are using the multimaster package in a system with two machines. One machine is a Turtlebot and the other one is a Raspberry Pi 3.

For our application, we use, among many others, two nodes that are called "radio_node_manager" and "radio_node_manager_main_controller". While using rosnode list we could only detect the second node from the remote machine. After a lot of hours of frustration, it turns out that the problem lies here.

I would suggest either removing this limitation and finding another way to exclude the multimaster-specific node_manager, or at the very least, mention this limitation on github and the ROS wiki.

If you are interested in the nodes, you can check the RADIO project github page.

Thanks for this great package and your time.

atiderko commented 7 years ago

i'm sorry for this trouble and thank you for report this problem! Perhaps it would help to remove '*' from filter for multimaster specific nodes?

gstavrinos commented 7 years ago

Removing the "*" would definitely help. I am not really sure if you use any prefixes to the "node_manager" string, and that's why I did not make a pull request.

atiderko commented 7 years ago

It was designed to use also namespaces, but in the practice we do not really need it. I will test it in our group before I commit this change.

gstavrinos commented 7 years ago

Ok! Thank you for your fast response! Happy coding!