search

fkinoshita / Telegraph

Write and decode morse
https://apps.gnome.org/app/io.github.fkinoshita.Telegraph
GNU General Public License v3.0
34 stars 19 forks source link

Remove modes and add more characters #9

Closed axtloss closed 1 year ago

axtloss commented 1 year ago

Allows users to simply type in the separate boxes to translate them instead of having to switch between modes, resolves #1

also adds some special characters

fkinoshita commented 1 year ago

Hi, thank you for the contribution.

Your commit is doing a lot of things though, it's adding more characters, making it possible to input or both text views, etc...

Could you please split these up into different commits?

And btw there's already a pull request that adds more characters so that's not needed on this pull request as well.

axtloss commented 1 year ago

Seems like I missed the pr for extra characters, I will revert those changes, which would also fix the issue about having one commit do multiple things as the only change then would be being able to input in both text views

axtloss commented 1 year ago

I reverted the changes to add extra characters, this pr now only removes the modes

fkinoshita commented 1 year ago

Thanks!