fkling / JSNetworkX

Build, process and analyze graphs in JavaScript (port of NetworkX)
https://felix-kling.de/jsnetworkx/
Other
761 stars 184 forks source link

Updating dependencies #85

Closed albertossilva closed 9 months ago

albertossilva commented 5 years ago

The main reason for this upgrade is npm audit. Now it has 0 vulnerabilties

njzjz commented 5 years ago

Feels good to me. Maybe I can use it instead the original one.

njzjz commented 5 years ago

Using your code with webpack, I catch the error Uncaught ReferenceError: regeneratorRuntime is not defined. What's wrong?

njzjz commented 4 years ago

Using your code with webpack, I catch the error Uncaught ReferenceError: regeneratorRuntime is not defined. What's wrong?

The problem is fixed by installing and importing regenerator-runtime.

albertossilva commented 4 years ago

So... @njzjz, should I install and add this dependency to my branch as well?

njzjz commented 4 years ago

So... @njzjz, should I install and add this dependency to my branch as well?

I add the following before import jsnetworkx:

global.regeneratorRuntime = require("regenerator-runtime");

and it works.

albertossilva commented 4 years ago

So.. it makes sense to add on the documentation, that this library is required when used in webpack.

On Mon, Dec 9, 2019, 17:28 Jinzhe Zeng notifications@github.com wrote:

So... @njzjz https://github.com/njzjz, should I install and add this dependency to my branch as well?

I add the following before import jsnetworkx:

global.regeneratorRuntime = require("regenerator-runtime");

and it works.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fkling/JSNetworkX/pull/85?email_source=notifications&email_token=AAFPFYLG2XYGQMCOZLB5QSDQXZWZVA5CNFSM4IGAJMZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJZBHQ#issuecomment-563318942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFPFYI2C7OXLR56D35FZJDQXZWZVANCNFSM4IGAJMZA .

albertossilva commented 9 months ago

Won't do