fkling / JSNetworkX

Build, process and analyze graphs in JavaScript (port of NetworkX)
https://felix-kling.de/jsnetworkx/
Other
761 stars 184 forks source link

Bump lodash from 3.3.1 to 4.17.21 #92

Open Joshnovski opened 7 months ago

Joshnovski commented 7 months ago

Modified entry point to align with the package name. Installing jsnetworkx places the entry point in node_modules/jsnetworkx/jsnetworkx.js. As a result, I changed "main": "node/index.js" to "main": "jsnetworkx.js" in package.json.

I also updated the Lodash dependency to 4.17.21 as Lodash versions before 4.17.21 are vulnerable to Command Injection via the template function.

Potential issues

When I imported the package into my react component via;

import * as jsnx from "jsnetworkx";

And hover over "jsnetworkx" There is a warning message which may or may not be problematic;

"Could not find a declaration file for module 'jsnetworkx'. 'c:/Users/joshm/Desktop/Coding/CS50W/Final Project/AlgorithmVisualizer/frontend/node_modules/jsnetworkx/jsnetworkx.js' implicitly has an 'any' type. Try npm i --save-dev @types/jsnetworkx if it exists or add a new declaration (.d.ts) file containing declare module 'jsnetworkx';ts(7016)"

Even with this occurring, I am having zero problems so far with the updated version.

Here is an image of my projects import to node_modules for reference;

node_modules