search

fknop / angular-pipes

Useful pipes for Angular
https://fknop.gitbook.io/angular-pipes/
MIT License
732 stars 157 forks source link

Allow empty strings on pipe parameters #66

Closed fantoine closed 6 years ago

fantoine commented 6 years ago

With previous implementation it was impossible to use this pipe to remove some patterns from the string. This change is a fix to allow empty strings as replacement variables.

Previous behavior: {{ 'my string' | replace:' ':'' }} returned 'my string'

Fixed behavior: {{ 'my string' | replace:' ':'' }} should return 'mystring'

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9e1c3ccef5e1760f6072dd244836d0f55c8e9c67 on fantoine:patch-1 into d1f6026e01a81244101cf0b905336e2701bda3b5 on fknop:master.

fknop commented 6 years ago

It seems CI does not pass.