search

fknop / angular-pipes

Useful pipes for Angular
https://fknop.gitbook.io/angular-pipes/
MIT License
732 stars 157 forks source link

Adding make-plural-string pipe. #79

Closed cpilson closed 5 years ago

cpilson commented 6 years ago

Requires new /src/utils/utils.ts isVowel() function.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f5a899e7e5059c8b40746c77723bfe6d917ee7de on cpilson:pluralize-string into 2615b1b842dd19a5a915c005cc85a8202e93d815 on fknop:master.

fknop commented 6 years ago

I have to admit that I'm not a fan of these english specific pipes, I know there probably is one or two english specific pipes in the library but I feel like this is a little bit too much and should probably be in your own project.

For example: isVowel():

Y might be considered a vowel for certain language, for others, not. In french, Y is always a vowel, in english, it might be considered both vowel and consonant, etc.

Same thing for the pluralizes which would not work with another language.

Even though I appreciate the effort but I think it should be kept separate so the library size is not increasing for people who don't need these pipes.