Multi-Connection Support - Githubissues

fknop / hapi-pagination

Hapi plugin to handle "custom" pagination

MIT License

63 stars 36 forks source link

Multi-Connection Support #45

Closed JasonAGiles closed 7 years ago

JasonAGiles commented 7 years ago

Addresses Issue #44 with parts of PR #17.

Changes Ext to a class to scope the config per call to register
Adds guard when registering on multiple connections at once to ensure a baseUri configuration option is passed
Adds tests for registering to individual connections as well as multiple connections at once

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 69dd3849bf4fbe1d170420b7e8d702eff9400d81 on JasonAGiles:multiple-connections into d957e5677a32874140b28105ef6ae9d282eed2ca on fknop:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 69dd3849bf4fbe1d170420b7e8d702eff9400d81 on JasonAGiles:multiple-connections into d957e5677a32874140b28105ef6ae9d282eed2ca on fknop:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling f8f632af6c03693575ec885f56dd2f25005d930d on JasonAGiles:multiple-connections into d957e5677a32874140b28105ef6ae9d282eed2ca on fknop:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 835b6b0bc3e766610a5d0a5b42d2443d28d0f298 on JasonAGiles:multiple-connections into d957e5677a32874140b28105ef6ae9d282eed2ca on fknop:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 835b6b0bc3e766610a5d0a5b42d2443d28d0f298 on JasonAGiles:multiple-connections into d957e5677a32874140b28105ef6ae9d282eed2ca on fknop:master.

fknop commented 7 years ago

Thanks, this looks good. I'll do a deeper review of the code this weekend or monday.