Optionally allow for a starting page index of 0 instead of 1

fknop / hapi-pagination

Hapi plugin to handle "custom" pagination

MIT License

63 stars 36 forks source link

Optionally allow for a starting page index of 0 instead of 1 #83

Closed icenine457 closed 4 years ago

icenine457 commented 4 years ago

Allow for starting pagination at zero instead of one

Fix-up some of the code to use ES6 conventions
Adds a .prettierrc.json configuration - I attempted to mirror the original style as best as possible here
Defaults to the original "1" index for pages
Top-level configuration option for using "0" index for pages
Adds unit tests to cover link functionality

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 5a56ea4f4bcdf493f7637062afeb1fe4aa30f921 on icenine457:add-zero-index into e055886e20d8d1126483dde9f7f1047f0ac3cc4d on fknop:master.

icenine457 commented 4 years ago

Once this is done, I have two further PRs that will be based upon this branch that I'd like to make. Those branches are here: ~~https://github.com/icenine457/hapi-pagination/tree/update-dependencies~~ Outdated, plz ignore :)

...and

https://github.com/icenine457/hapi-pagination/tree/hapi-19

fknop commented 4 years ago

LGTM :) I'll make one release with your two other PRs