search

fknop / hapi-pagination

Hapi plugin to handle "custom" pagination
MIT License
63 stars 36 forks source link

Make hapi v19 a peer rather than a direct dependency #86

Closed devinivy closed 4 years ago

devinivy commented 4 years ago

I recommend making hapi 19 a peer rather than a direct dependency, as it's more flexible for consumers and I believe has no effect of this module.

If hapi v20 comes out and this plugin isn't broken, then this plugin would just require an update to the peer dependency version to include both v19 and v20, and hapi-pagination could publish a new minor version rather than a major version. And before that is complete, folks would still be able to upgrade their version of hapi if they can live with the peer dependency warning from npm. Using a peer dependency would also avoid unneeded duplicate installs of hapi in case there is an incidental version conflict (e.g. if I need to run 19.0.0 in my project but this plugin lists a dependency on 19.1.1+).

I know v4 isn't published yet, so I figured now might be a good time to offer this!

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling adc5f1ce5d5c55489bfcc486849185202afeb73d on devinivy:hapi-v19-peer into 6addeddd63e0f72cd32b5ce4d72eb0c7bd476094 on fknop:master.

fknop commented 4 years ago

Yep make sense!