search

fkorotkov / intellij-thrift

Apache License 2.0
88 stars 75 forks source link

Uncompatible With GoLand 2020.2 and 2020.3 #100

Closed WeiweiGao closed 3 years ago

WeiweiGao commented 3 years ago

I've tried basically all plugin version, none of it worked, remind me as follows: Plugin 'Thrift Support' requires plugin 'com.intellij.modules.java' to be installed

bogdanovich commented 3 years ago

OK, so I made it work by editing it vim plugin.jar select plugin.xml and update

<depends>com.intellij.modules.java</depends>

to

<depends optional="true">com.intellij.modules.java</depends>
LiZhenNet commented 3 years ago

I have build it，it work well with GoLand 2020.3 thrift.zip

saturn4er commented 3 years ago

@WeiweiGao already fixed, and already in Marketplace for latest Golands

fkorotkov commented 3 years ago

@saturn4er thank you!

edwardotis commented 3 years ago

@saturn4er I do not see this in the MarketPlace for Goland 2020.2.4 ?

saturn4er commented 3 years ago

Hi @edwardotis actually, plugin require some features from idea 2020.3. Is it really necessary to use old Goland release?

edwardotis commented 3 years ago

@saturn4er The Bazel plugin has never been updated for 2020.3.x releases of intellij or Goland, so I had reverted to 2020.2.x Goland to get that.

However, I just got my project running with Intellij's goland plugin in Intellij 2020.2.x, and the thrift plugin is available. (as well as bazel plugin).

So, I'm all set. Thanks!

isopropylcyanide commented 3 years ago

+1 Bazel plugin incompatibility forces us to use 2020.2.x Goland. Is there a way to make it work for 2020.2?