search

fkrauthan / wp-mpdf

Print WordPress posts as PDF. Optional with Geshi highlighting.
55 stars 23 forks source link

Can not disable "needs login" with PHP 8 #23

Closed timurc closed 1 year ago

timurc commented 2 years ago

Hey,

if I try to disable the checkbox "needs login" in the admin panel, it re-enables itself when I click "save". So, effectively, I can not turn it off. Sometimes, it stays unchecked but after re-loading the page, it is enabled again.

I did not see an error in the logs.

It just happens with PHP 8, with php 7.4 it works fine.

And thanks so much for updating mpdf! It will also be OK for me to use 7.4 for now, just wanted to raise this.

fkrauthan commented 2 years ago

Yeah I've tried to debug that but couldn't reproduce it. That checkbox works exactly the same as others. If you have any idea I am happy to take pull requests to fix that. There should be 0 reason for this strange behavior. Especially PHP version dependent.