Running amalgamation on Windows produces huge diff due to changes from LF to CRLF, which is a valid behavior of Python's built-in open() function without specifying the newline parameter.
That isn't desirable and would confuse contributors who want to run amalgamation on Windows.
So, this PR has fixed the above issue by modifying the amalgamate.py script, updating the tool/amalgamation/CHANGELOG.md file.
[x] The documentation is updated if you added/changed a feature.
Please don't
The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.
Running amalgamation on Windows produces huge diff due to changes from LF to CRLF, which is a valid behavior of Python's built-in
open()function without specifying thenewlineparameter.That isn't desirable and would confuse contributors who want to run amalgamation on Windows.
So, this PR has fixed the above issue by modifying the
amalgamate.pyscript, updating thetool/amalgamation/CHANGELOG.mdfile.Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdefs or other means.