fktn-k / fkYAML

A C++ header-only YAML library
MIT License
69 stars 7 forks source link

Fixed parser crashes on a sequence right after the directives end marker #327

Closed fktn-k closed 5 months ago

fktn-k commented 5 months ago

The fkYAML parser in the latest develop branch crashes with the following valid YAML snippets (taken from the official YAML test suite Z9M4/in.yaml):

%TAG !e! tag:example.com,2000:app/
---
- !e!foo "bar"

After some investigation, it's turned out that the parser doesn't process directive end markers (denoted with ---) properly.
So, this PR has fixed the parser's issue and added a test case to validate the change.

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

Please don't

github-actions[bot] commented 5 months ago

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 4afb6ed81da0d8f233979b70bf0864c8175905ba. You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr327.zip
ID 1453640802
URL https://github.com/fktn-k/fkYAML/actions/runs/8862167742/artifacts/1453640802
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8862167742

Details


Totals Coverage Status
Change from base Build 8860575999: 0.0%
Covered Lines: 3541
Relevant Lines: 3541

💛 - Coveralls