When the Bash scripts for running clang-format and amalagamation on Windows, they ends up with errors which says no such file/directory.
This is because (1) Python distributions for Windows have no python3 executable and (2) binaries are stored in the venv\Scripts directory, not in the venv/bin directory, when Python venv module is used on Windows.
To fix the above issues, this PR has added platform switches using the output from the uname command.
Both on Ubuntu22.04 with WSL2 and Windows10 with Git for Windows (2.44.0-windows.1), the scripts now work as expected.
[x] The documentation is updated if you added/changed a feature.
Please don't
The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.
When the Bash scripts for running clang-format and amalagamation on Windows, they ends up with errors which says no such file/directory.
This is because (1) Python distributions for Windows have no
python3
executable and (2) binaries are stored in thevenv\Scripts
directory, not in thevenv/bin
directory, when Python venv module is used on Windows.To fix the above issues, this PR has added platform switches using the output from the
uname
command.Both on Ubuntu22.04 with WSL2 and Windows10 with Git for Windows (2.44.0-windows.1), the scripts now work as expected.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.