fktn-k / fkYAML

A C++ header-only YAML library
MIT License
69 stars 7 forks source link

Fixed parse error on block sequences with child block mappings split by a newline code #333

Closed fktn-k closed 5 months ago

fktn-k commented 5 months ago

This PR has fixed parse errors which the current parser emits on a block sequence containing child block mappings, like the following valid YAML snippet (taken from the official YAML test suite 229Q):

-
  name: Mark McGwire
  hr:   65
  avg:  0.278
-
  name: Sammy Sosa
  hr:   63
  avg:  0.288

The parser now interprets - followed by a newline code (either CR, LF, or CR+LF) as a block sequence entry prefix and the change is validated by adding the above YAML snippet to the test suite.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

Please don't

github-actions[bot] commented 5 months ago

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 73d095fae00084a350d1df55a5ec0a43254709c6. You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr333.zip
ID 1466165933
URL https://github.com/fktn-k/fkYAML/actions/runs/8919991614/artifacts/1466165933
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8919991614

Details


Totals Coverage Status
Change from base Build 8915567014: 0.0%
Covered Lines: 3581
Relevant Lines: 3581

💛 - Coveralls