fktn-k / fkYAML

A C++ header-only YAML library
MIT License
69 stars 7 forks source link

Fixed error on node properties for child block sequences #338

Closed fktn-k closed 5 months ago

fktn-k commented 5 months ago

This PR has fixed an assertion failure (in the debug mode) or an incorrect parse result (in the release mode) each of which occurs when the parser tries to deserialize a YAML snippet where node properties (a tag, a anchor, or both) is specified to a child block sequence, like the following one:

foo: !!seq # This property causes the assertion failure
- true
- 123

The root cause was that the parser didn't set node properties to an appropriate block sequence node and tried to parse a subsequent scalar node with the !!seq tag.
Several test cases have also been added to check if the above issue has been resolved.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

Please don't

github-actions[bot] commented 5 months ago

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 6cdf2816211a9129163a5b4750010c777b360cd9. You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr338.zip
ID 1471300559
URL https://github.com/fktn-k/fkYAML/actions/runs/8942162541/artifacts/1471300559
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8942162541

Details


Totals Coverage Status
Change from base Build 8939759739: 0.0%
Covered Lines: 3601
Relevant Lines: 3601

💛 - Coveralls