fktn-k / fkYAML

A C++ header-only YAML library
MIT License
69 stars 7 forks source link

Fix parse error on flow containers containing child flow containers #345

Closed fktn-k closed 4 months ago

fktn-k commented 4 months ago

This PR has fixed parse errors on flow style containers which contains child flow style containers like the following valid JSON-like YAML snippet:

{
  "a": [
    "foo",
    "bar"
  ],
  "b": [
    [
      true,
      false
    ],
    [
      123,
      456
    ]
  ]
}

The root cause is that the fkYAML deserializer didn't properly handle nested flow style container prefix events.
To validate the fix, the test suite has also been updated by adding several test cases for the deserialization feature.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

Please don't

github-actions[bot] commented 4 months ago

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit c91ac69faf8a73a55309559efed7ce8be6ff8a72. You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr345.zip
ID 1517137061
URL https://github.com/fktn-k/fkYAML/actions/runs/9148221027/artifacts/1517137061
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9148221027

Details


Totals Coverage Status
Change from base Build 9147143461: 0.0%
Covered Lines: 3752
Relevant Lines: 3752

💛 - Coveralls