fktn-k / fkYAML

A C++ header-only YAML library
MIT License
69 stars 7 forks source link

Fix parse error on flow container keys #346

Closed fktn-k closed 4 months ago

fktn-k commented 4 months ago

This PR has fixed parse errors on flow container keys like the following valid YAML snippet:

{foo: bar}: 123
[true,false]: 3.14

The root cause is that the fkYAML deserializer wrongly assumed that flow containers weren't used as a mapping key.
To validate the fix, the test suite has also been updated by adding several relevant test cases for the deserializer.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

Please don't

github-actions[bot] commented 4 months ago

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 530a897d44896bc0a01177bdd5ecd942b2a45dc1. You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr346.zip
ID 1538087095
URL https://github.com/fktn-k/fkYAML/actions/runs/9240012472/artifacts/1538087095
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9240012472

Details


Totals Coverage Status
Change from base Build 9237506365: 0.0%
Covered Lines: 3874
Relevant Lines: 3874

💛 - Coveralls